added two new screenshots to curiefense integration #5038
Conversation
Signed-off-by: Raman Thakur <[email protected]>
|
🚀 Preview for commit e4d08eb at: https://652960322e23ff06288da114--layer5.netlify.app |
There was a problem hiding this comment.
@thakuraman24 Does your screenshot represent the Curiefense Integration.?
Also, we need at least four screenshots with the specific integration.
Take this as reference https://github.com/layer5io/layer5/pull/4990 and Meshmap-designer Walkthrough
Thank you for your contribution.
|
@singh1203 I am having two problems while contributing to this issue -->The first one is that I am totally new to this cloud-native field and don't know how to design these Meshmaps of different integrations, so can you provide me with some references that I can use to create a CURIEFENSE SPECIFIC Meshmap? -->The second one is that the LIGHTHOSECI test for the above PR failed do you have any idea what could be the reason for that? |
Thank you for pointing it out, feel free to open the thread in slack or discussion forum on Layer5 discuss forum where me along with other member's will help you out. |
There was a problem hiding this comment.
@thakuraman24 thankyou for working on it, make sure these acceptance test follows, and mark them as completed, also regarding design you don't need to create your own, you can use published design and clone them and take screenshot of them (You can do that in meshmap)
- Ensure your screenshot represents the use of a few specific integrations.
- The screenshot from the Designer mode should contain a valid design, refer to meshery catalog to use and view published designs.
- Add both Dark Mode and Light Mode screenshots.
- The screenshot should not be a snippet, take the full screenshot of your browser.
- Use Incognito mode on Chrome browser, to ensure your bookmark bar or any other items are not shown in the screenshot/video.
|
Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST. |
Description
This PR fixes #4884
Notes for Reviewers
Signed commits